Adds aarch64_none_linux_gnu support #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexdae
reviewed
Apr 22, 2024
|
Sorry, I added |
I rebased from your HEAD.
Sorry, I'm really not skillful at adding this test. I did test it with my own project at https://github.com/google/pcie_lmt/blob/06ff42cb8724f75cd5fd6e081b03b3df3e42d2a3/BUILD#L60 |
|
This should be ready to go, thanks a lot for adding it. I am going to release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward adding aarch64_none_linux_gnu following the existing scheme.
There seems to be some unnecessary formatting rearrangements. Those are automatically done by the bazel style formatter embedded in my editor. I have good confidence in what it's doing.